Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-blocking socket reads for rotctl track responses #109

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

bjorgan
Copy link
Member

@bjorgan bjorgan commented Nov 15, 2022

Ref. #108: Flyby singletrack UI can
become unresponsive during tracking since we wait for confirmation of
the previous response before we try to set a new position.

These changes modify the socket read to be non-blocking, so that we can
return back to the UI loop when the full response is not available yet,
and still retain the mechanism with the previous response being required
before we are allowed to set a new position.

This does not fully solve #108 since
we will have an issue with the hamlib status windows, but I'll continue
on that in a different branch and merge this already now so that the
user experience can be improved.

@bjorgan bjorgan merged commit 15667b4 into master Nov 15, 2022
@bjorgan bjorgan deleted the feature/nonblocking-rotctl-track branch November 15, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant