Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing styles fix #205

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

Missing styles fix #205

wants to merge 38 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 11, 2019

  • Channel setting's additional options and edit message retention modal style missing fix
  • search modal files list missing style fix

scss/modules/modals/_channel.scss Outdated Show resolved Hide resolved
scss/modules/inputs/_messaging.scss Outdated Show resolved Hide resolved
scss/modules/inputs/_messaging.scss Outdated Show resolved Hide resolved
scss/modules/inputs/_base.scss Show resolved Hide resolved
scss/modules/modals/_base.scss Outdated Show resolved Hide resolved
scss/modules/modals/_base.scss Outdated Show resolved Hide resolved
scss/modules/modals/_preferences.scss Outdated Show resolved Hide resolved
scss/modules/modals/_preferences.scss Outdated Show resolved Hide resolved
scss/modules/modals/_preferences.scss Outdated Show resolved Hide resolved
scss/modules/inputs/_base.scss Show resolved Hide resolved
scss/modules/inputs/_base.scss Outdated Show resolved Hide resolved
scss/modules/inputs/_select.scss Outdated Show resolved Hide resolved
scss/modules/inputs/_select.scss Outdated Show resolved Hide resolved
scss/modules/messaging/_threads.scss Outdated Show resolved Hide resolved
scss/modules/messaging/_threads.scss Outdated Show resolved Hide resolved
scss/modules/messaging/_threads.scss Outdated Show resolved Hide resolved
scss/modules/messaging/_threads.scss Outdated Show resolved Hide resolved
scss/modules/messaging/_unreads.scss Outdated Show resolved Hide resolved
scss/modules/messaging/_unreads.scss Outdated Show resolved Hide resolved
scss/styles.scss Outdated Show resolved Hide resolved
Copy link
Collaborator

@mastermel mastermel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my follow up comments, and also make the changes requested by the linter. Please don't simply resolve the linter's comments. It helps keep the codebase consistent to follow these suggestions. If you feel like any of the linter rules are unnecessary than please submit a separate PR with your suggested changes there.

Thanks!

scss/modules/modals/_base.scss Outdated Show resolved Hide resolved
scss/modules/modals/_channel.scss Outdated Show resolved Hide resolved
scss/modules/flexpane/_files.scss Outdated Show resolved Hide resolved
scss/modules/flexpane/_files.scss Outdated Show resolved Hide resolved
scss/modules/flexpane/_files.scss Outdated Show resolved Hide resolved
scss/modules/flexpane/_files.scss Outdated Show resolved Hide resolved
scss/modules/header/_base.scss Outdated Show resolved Hide resolved
scss/modules/header/_base.scss Show resolved Hide resolved
scss/modules/header/_base.scss Show resolved Hide resolved
scss/modules/header/_base.scss Show resolved Hide resolved
scss/modules/inputs/_base.scss Show resolved Hide resolved
scss/modules/inputs/_base.scss Outdated Show resolved Hide resolved
scss/modules/inputs/_base.scss Outdated Show resolved Hide resolved
scss/modules/header/_base.scss Outdated Show resolved Hide resolved
scss/modules/flexpane/_files.scss Outdated Show resolved Hide resolved
scss/modules/flexpane/_channel.scss Outdated Show resolved Hide resolved
scss/modules/header/_base.scss Outdated Show resolved Hide resolved
scss/modules/flexpane/_files.scss Outdated Show resolved Hide resolved
@@ -97,4 +99,4 @@
@import "modules/pages/apps";
@import "modules/pages/legal";
@import "modules/pages/oauth";
@import "modules/pages/spaces";
@import "modules/pages/spaces";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline


.p-unreads_view {
background: $color-base;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants