feat(test): Implementing a new test framework for core lightning #436

Triggered via push July 5, 2023 17:18

vincenzopalazzo

pushed c19f582

macros/test-framework-v2

Status Success

Total duration 1m 23s

Artifacts –

build.yml

on: push

Lints

43s

Matrix: Build

Annotations

39 warnings

`crate` references the macro call's crate: testing/src/lib.rs#L30

warning: `crate` references the macro call's crate --> testing/src/lib.rs:30:17 | 30 | use crate::DEFAULT_TIMEOUT; | ^^^^^ help: to reference the macro definition's crate, use: `$crate` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#crate_in_macro_def = note: `#[warn(clippy::crate_in_macro_def)]` on by default

very complex type used. Consider factoring parts into `type` definitions: plugin/src/plugin.rs#L50

warning: very complex type used. Consider factoring parts into `type` definitions --> plugin/src/plugin.rs:50:14 | 50 | on_init: Option<Arc<dyn Fn(&mut Plugin<T>) -> Value>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

the following explicit lifetimes could be elided: 'c: plugin/src/commands/mod.rs#L27

warning: the following explicit lifetimes could be elided: 'c --> plugin/src/commands/mod.rs:27:5 | 27 | fn call_void<'c>(&self, _plugin: &mut Plugin<T>, _request: &'c serde_json::Value) {} | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 27 - fn call_void<'c>(&self, _plugin: &mut Plugin<T>, _request: &'c serde_json::Value) {} 27 + fn call_void(&self, _plugin: &mut Plugin<T>, _request: &serde_json::Value) {} |

this lifetime isn't used in the function definition: plugin/src/commands/mod.rs#L18

warning: this lifetime isn't used in the function definition --> plugin/src/commands/mod.rs:18:13 | 18 | fn call<'c>( | ^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default

redundant clone: plugin/src/commands/builtin.rs#L71

warning: redundant clone --> plugin/src/commands/builtin.rs:71:60 | 71 | let init: InitConf = serde_json::from_value(request.to_owned()).unwrap(); | ^^^^^^^^^^^ help: remove this | note: this value is dropped without further use --> plugin/src/commands/builtin.rs:71:53 | 71 | let init: InitConf = serde_json::from_value(request.to_owned()).unwrap(); | ^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone = note: `#[warn(clippy::redundant_clone)]` on by default

very complex type used. Consider factoring parts into `type` definitions: plugin/src/commands/builtin.rs#L56

warning: very complex type used. Consider factoring parts into `type` definitions --> plugin/src/commands/builtin.rs:56:25 | 56 | pub(crate) on_init: Option<Arc<dyn Fn(&mut Plugin<T>) -> Value>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

single-character string constant used as pattern: plugin_macros/src/attr_parser.rs#L39

warning: single-character string constant used as pattern --> plugin_macros/src/attr_parser.rs:39:47 | 39 | let value = value.to_string().replace("\"", ""); | ^^^^ help: try using a `char` instead: `'\"'` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default

this `impl` can be derived: plugin_macros/src/plugin.rs#L61

warning: this `impl` can be derived --> plugin_macros/src/plugin.rs:61:1 | 61 | / impl Default for PluginDeclaration { 62 | | fn default() -> Self { 63 | | Self { 64 | | state: None, ... | 70 | | } 71 | | } | |_^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls = note: `#[warn(clippy::derivable_impls)]` on by default = help: remove the manual implementation... help: ...and instead derive it | 9 + #[derive(Default)] 10 | pub struct PluginDeclaration { |

this expression creates a reference which is immediately dereferenced by the compiler: plugin_macros/src/plugin.rs#L45

warning: this expression creates a reference which is immediately dereferenced by the compiler --> plugin_macros/src/plugin.rs:45:47 | 45 | let mut inner = KTokenStream::new(&inner); | ^^^^^^ help: change this to: `inner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

this expression creates a reference which is immediately dereferenced by the compiler: plugin_macros/src/plugin.rs#L30

warning: this expression creates a reference which is immediately dereferenced by the compiler --> plugin_macros/src/plugin.rs:30:47 | 30 | let mut inner = KTokenStream::new(&inner); | ^^^^^^ help: change this to: `inner` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

very complex type used. Consider factoring parts into `type` definitions: plugin/src/plugin.rs#L50