Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for dynamic scope definition via api #16

Closed
eabili0 opened this issue Sep 12, 2019 · 2 comments
Closed

Allow for dynamic scope definition via api #16

eabili0 opened this issue Sep 12, 2019 · 2 comments

Comments

@eabili0
Copy link
Contributor

eabili0 commented Sep 12, 2019

The scopes Whisper can handle today are defined in build time.

It would be interesting to have them defined in runtime, via API, so Whisper registered Clients can inform their own scopes.

@eabili0 eabili0 added the enhancement New feature or request label Sep 12, 2019
@claudiosegala
Copy link
Contributor

claudiosegala commented Oct 28, 2019

@abilioesteves just to check, these are the steps for this issue:

  1. Create a Scopes Table for scopes definitions;
  2. Seed the current default scopes during the build;
  3. Improve the retrieval of scopes to retrieve from the database;
  4. Create an API to CRUD the Scopes Table;

PS: Scopes Table fields would be ClientID, Description, Alias, Details, Scope and ID. ClientID would be nullable so that null meant that this scope is for all.
PS2: Someone can only edit/delete Scopes that have the same client id.

@eabili0 eabili0 added this to the Admin page milestone Dec 30, 2019
@eabili0 eabili0 added construction and removed enhancement New feature or request labels Dec 30, 2019
@eabili0
Copy link
Contributor Author

eabili0 commented Dec 30, 2019

@claudiosegala, this issue is now part of a more broad Milestone. The applications will now be registered by the user through a Whisper dashboard.

The proposed Scopes Table will have a n:1 relationship with an Applications Table.

For that reason, I'm sunsetting this issue. The efforts will now be redirected to issues #59 and #58 .

Thanks!

@eabili0 eabili0 closed this as completed Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants