Issue#53 - Update Hydra's environment variables #54
Conversation
claudiosegala
changed the title
|
@abilioesteves do you know any way to stress test every variable? |
|
@claudiosegala, what do you mean? |
| @@ -87,13 +93,13 @@ From the project root folder, fire the following commands to execute this projec | |||
| --shutdown-time 10 \ | |||
| ``` | |||
|
|
|||
| 4. Authorize application on hydra | |||
|
|
|||
| 5. Authorize application on hydra | |||
There was a problem hiding this comment.
@claudiosegala, now that we have an example web app, couldn’t we just remove sections 5 and 6 and just add the example app as dependency at the available docker-compose.yml file?
There was a problem hiding this comment.
@abilioesteves, isn't it better to just add the whisper-examples link, instead of replacing?
There was a problem hiding this comment.
The example we created is much better than the default one from Hydra. We'll have a docker image available for the example, making it easy for future users to execute Whisper and get a taste for its functionalities. The less cognitive overhead we have on our documentation, the better users will understand how Whisper works. Could you please do it, @claudiosegala? I'll start a docker image generation pipeline for the Web app whisper example.
I mean that I change the variables and from what I saw, it seemed to work. But I do not think that the tests I made covered the usages of every variable that I changed. |
|
@claudiosegala, I think we should open a new issue to discuss how to test all the important variables (so Whisper can work nicely with Hydra). It's a complicated subject, since we are talking about integration testing (not unit testing). We should then discuss how to proceed with the creation of an Integration Testing pipeline, and then stress-out these variables. |
|
@abilioesteves, I agree with you. Should I open this issue? |
|
@claudiosegala, yes, please |
Fix #53, start #12 and some minor improvements.