Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce internal config object #263

Merged
merged 4 commits into from
Jan 18, 2025
Merged

Conversation

mvantellingen
Copy link
Member

  • chore: use process.emitWarning instead of console
  • feat: create and pass internal config object
  • chore: remove usage of ctMock.start/stop
  • chore: throw error if product type doesn’t exist

Instead of having our custom warnDeprecation, use process.emitWarning
instead
Create a config object which contains the `storage` and a new boolean
`strict` to make the mock service more strict in the near future
We deprecated this a while ago
When in strict mode an error is returned when a product is created with
a non-existing product type
Copy link

changeset-bot bot commented Jan 18, 2025

🦋 Changeset detected

Latest commit: aa7149e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@labdigital/commercetools-mock Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mvantellingen mvantellingen merged commit 7e84007 into main Jan 18, 2025
11 checks passed
@mvantellingen mvantellingen deleted the feature/config-obj branch January 18, 2025 16:15
@github-actions github-actions bot mentioned this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant