fix: create proper redirect for non-locale paths #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvantellingen
force-pushed
the
feat/fix-double-redirect
branch
from
f3579de to
35e3f25
Compare
When the path didn’t have a locale but the `localePrefix` was set to
`always` we let next-intl redirect the user to
`/${defaultLocale}/${path}`. On visit we then rewrote that to
`/${defaultPathLocale}/${path}` and redirect the client again.
This makes sure we do the redirect ourselves skipping an extra redirect
mvantellingen
force-pushed
the
feat/fix-double-redirect
branch
from
35e3f25 to
a8b60a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the path didn’t have a locale but the
localePrefixwas set toalwayswe let next-intl redirect the user to/${defaultLocale}/${path}. On visit we then rewrote that to/${defaultPathLocale}/${path}and redirect the client again.This makes sure we do the redirect ourselves skipping an extra redirect