Skip to content
This repository has been archived by the owner on Apr 21, 2022. It is now read-only.

docker.cmd is hard to add/modify to #19

Open
bfirsh opened this issue Feb 7, 2017 · 1 comment
Open

docker.cmd is hard to add/modify to #19

bfirsh opened this issue Feb 7, 2017 · 1 comment

Comments

@bfirsh
Copy link

bfirsh commented Feb 7, 2017

It is difficult to modify docker.cmd by the consumer of the label, which meant I didn't use it for Whalebrew. See here for more details: whalebrew/whalebrew#6

Instead, I opted for specific labels for each thing I wanted to configure. Eg. the location to mount each volume, the port to expose each port as, and so on. See here: https://github.com/bfirsh/whalebrew#configuration-1

This means I can construct and add Docker options at runtime, and is much safer because it doesn't allow arbitrary options to be passed. Also, it could potentially work with rkt too.

@lizrice
Copy link
Contributor

lizrice commented Mar 7, 2017

I like the way you've done that @bfirsh. Pinging @garethr @mhausenblas @amouat - wdyt, should we look at moving to this style in label-schema?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants