Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider label-schema.org? #6

Closed
beddari opened this issue Jan 27, 2017 · 4 comments
Closed

Consider label-schema.org? #6

beddari opened this issue Jan 27, 2017 · 4 comments

Comments

@beddari
Copy link

beddari commented Jan 27, 2017

Hi, awesome project, seems like this idea was finally ready for someone to pick up and run with!!

Would you consider adopting http://label-schema.org/rc1/ ? Not sure if you are aware of it, but I think it would make a lot of sense in this context

@bfirsh
Copy link
Member

bfirsh commented Jan 27, 2017

Yep, for sure! There just wasn't anything useful in there I could use. "docker.cmd" is not flexible enough. Description is something we could adopt to describe what packages are, perhaps.

The Whalebrew labels are something that could be incorporated into label schema, perhaps.

@beddari
Copy link
Author

beddari commented Jan 27, 2017

Care to expand on why docker.cmd wasn't useful? I'd say this use case would be a primary acid test for that to be useful. So much as if you've found it not to work we should work to get it changed.

@bfirsh
Copy link
Member

bfirsh commented Jan 27, 2017

Several reasons:

  1. The command-line arguments need to be changed at runtime based on various things, and splicing additional/changed arguments into an arbitrary command-line string is very difficult and fragile. Splicing with a list of arguments is a bit better, but still fragile.
  2. I want to be able to store the configuration as YAML so it is user configurable. I could have stored just a "docker run" command which the user could edit, but then that has the same problem as (1).
  3. I want the configuration to be machine readable, similar to (2).
  4. I intentionally want to limit what commands do, and if they do something scary (e.g. mount arbitrary files, privileged access) I want to warn/ask the user before it is run. This is hard to do with an arbitrary run command.

Thus, I opted for specifying the options separately as labels (environment and volumes) instead of just an arbitrary docker run command.

@bfirsh
Copy link
Member

bfirsh commented Feb 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants