Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the input handling of session template creation API #3238

Closed
achimnol opened this issue Dec 10, 2024 · 1 comment
Closed

Clarify the input handling of session template creation API #3238

achimnol opened this issue Dec 10, 2024 · 1 comment
Labels
comp:manager Related to Manager component type:refactor Refactor codes or add tests.
Milestone

Comments

@achimnol
Copy link
Member

In lablup/backend.ai-manager#480, #1406, and #1668, the session template creation API became able to process only the yaml.safe_load_all()'s return value, which is a generator.

It may crash with the json.loads() output as it would just return a dict, when the client submits a JSON data instead of YAML data. This is a potential bug.

Along with #3183, we need to clarify whether the API handler decomposes the input parameter object and applies individual validation to its parts or delegate the entire parameter interpretation to a structured schema (e.g., Pydantic).

@achimnol achimnol added comp:manager Related to Manager component type:refactor Refactor codes or add tests. labels Dec 10, 2024
@achimnol achimnol added this to the 24.12 milestone Dec 10, 2024
@achimnol
Copy link
Member Author

Oops.. GitHub said it had failed to create the issue but...

@achimnol achimnol closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component type:refactor Refactor codes or add tests.
Projects
None yet
Development

No branches or pull requests

1 participant