Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle request format changes on session template API #1668

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Oct 29, 2023

After #1406 is merged, request format for session template creation/update API has changed.
This PR updates the parameter of UPDATE API handler accordingly.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version

@fregataa fregataa added this to the 23.09 milestone Oct 29, 2023
@fregataa fregataa self-assigned this Oct 29, 2023
@github-actions github-actions bot added comp:manager Related to Manager component size:XS ~10 LoC labels Oct 29, 2023
@fregataa fregataa requested a review from achimnol October 29, 2023 06:21
@kyujin-cho kyujin-cho changed the title fix: follow-up updated session template create API fix: reflect request scheme changes on session template update API Oct 30, 2023
@kyujin-cho kyujin-cho changed the title fix: reflect request scheme changes on session template update API fix: handle request format changes on session template API Oct 30, 2023
@kyujin-cho kyujin-cho added this pull request to the merge queue Oct 30, 2023
@kyujin-cho kyujin-cho removed this pull request from the merge queue due to a manual request Oct 30, 2023
@kyujin-cho kyujin-cho added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 6d96aca Oct 30, 2023
18 checks passed
@kyujin-cho kyujin-cho deleted the fix/followup-update-sessiontpl-api branch October 30, 2023 05:50
kyujin-cho pushed a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:XS ~10 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants