feat(BA-593): Configure the logging module's config file to use Pydantic #2834
+244
−269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achimnol
requested changes
Jan 13, 2025
Yaminyam
changed the title
Comment on lines
+32
to
+48
| class HostPortPair(BaseSchema): | ||
| host: str = Field(examples=["127.0.0.1"]) | ||
| port: int = Field(gt=0, lt=65536, examples=[8201]) | ||
|
|
||
| def __repr__(self) -> str: | ||
| return f"{self.host}:{self.port}" | ||
|
|
||
| def __str__(self) -> str: | ||
| return self.__repr__() | ||
|
|
||
| def __getitem__(self, *args) -> int | str: | ||
| if args[0] == 0: | ||
| return self.host | ||
| elif args[0] == 1: | ||
| return self.port | ||
| else: | ||
| raise KeyError(*args) |
There was a problem hiding this comment.
One thing I’m wondering is why the HostPortPair class is inside the logging package.
It seems like it should be in a different package.
There was a problem hiding this comment.
We support several logging tools and may support more in the future.
(ex, graylog, logstash)
Since these logging tools require the host address by default, we've just separated that part into a common setting.
ref.
|
Please resolve the conflict. @Yaminyam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #3518 (BA-593)
Ensure that the logging module's config file is validated using pydantic.
Make logging module-specific settings that wsproxy implements in its own config file common to the logging module.
If you are working on replacing trafaret with pydantic and you have resolved any dependencies on the logging module, you can replace
config_pydantic.pywithconfig.pyChecklist: (if applicable)