Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Container preparation step in Agent #3267

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

achimnol
Copy link
Member

@achimnol achimnol commented Dec 18, 2024

resolves #3266 (BA-9)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

@github-actions github-actions bot added comp:agent Related to Agent component size:S 10~30 LoC type:refactor Refactor codes or add tests. labels Dec 18, 2024
Copy link
Member Author

achimnol commented Dec 18, 2024

@achimnol achimnol changed the title refactor: No need to keep container_id in KernelResourceSpec refactor: Container preparation step in Agent Dec 18, 2024
@achimnol achimnol added the skip:changelog Make the action workflow to skip towncrier check label Dec 18, 2024
@Yaminyam Yaminyam requested a review from Copilot December 18, 2024 09:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@achimnol achimnol force-pushed the refactor/container-prep branch from ab4be44 to c76bab8 Compare December 19, 2024 04:59
@github-actions github-actions bot added comp:installer Related to Installer size:L 100~500 LoC and removed size:S 10~30 LoC labels Dec 20, 2024
@achimnol achimnol force-pushed the refactor/container-prep branch from 0f26f64 to ae92013 Compare December 20, 2024 15:28
@github-actions github-actions bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Dec 20, 2024
@achimnol achimnol force-pushed the refactor/container-prep branch from ae92013 to fc7d6ce Compare December 20, 2024 15:29
@achimnol achimnol force-pushed the refactor/container-prep branch from fc7d6ce to bbb8b24 Compare December 23, 2024 16:03
@achimnol achimnol added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit c62d12b Dec 23, 2024
19 of 21 checks passed
@achimnol achimnol deleted the refactor/container-prep branch December 23, 2024 16:08
@achimnol achimnol added this to the 24.09 milestone Dec 24, 2024
Copy link

Backport to is failed. Please backport manually.

lablup-octodog pushed a commit that referenced this pull request Dec 24, 2024
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 3267
github-merge-queue bot pushed a commit that referenced this pull request Dec 24, 2024
Co-authored-by: Joongi Kim <joongi@lablup.com>
Copy link

Backport to 24.09 is failed. Please backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:agent Related to Agent component comp:installer Related to Installer size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check type:refactor Refactor codes or add tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor container preparation step
1 participant