-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Container preparation step in Agent #3267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:agent
Related to Agent component
size:S
10~30 LoC
type:refactor
Refactor codes or add tests.
labels
Dec 18, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
achimnol
changed the title
refactor: No need to keep container_id in KernelResourceSpec
refactor: Container preparation step in Agent
Dec 18, 2024
achimnol
added
the
skip:changelog
Make the action workflow to skip towncrier check
label
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
achimnol
force-pushed
the
refactor/container-prep
branch
from
December 19, 2024 04:59
ab4be44
to
c76bab8
Compare
2 tasks
github-actions
bot
added
comp:installer
Related to Installer
size:L
100~500 LoC
and removed
size:S
10~30 LoC
labels
Dec 20, 2024
achimnol
force-pushed
the
refactor/container-prep
branch
from
December 20, 2024 15:28
0f26f64
to
ae92013
Compare
achimnol
force-pushed
the
refactor/container-prep
branch
from
December 20, 2024 15:29
ae92013
to
fc7d6ce
Compare
- It is just enough to append "CID={cid}" in resource.txt after creating the container.
achimnol
force-pushed
the
refactor/container-prep
branch
from
December 23, 2024 16:03
fc7d6ce
to
bbb8b24
Compare
Backport to is failed. Please backport manually. |
lablup-octodog
pushed a commit
that referenced
this pull request
Dec 24, 2024
Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3267
Backport to 24.09 is failed. Please backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:agent
Related to Agent component
comp:installer
Related to Installer
size:M
30~100 LoC
skip:changelog
Make the action workflow to skip towncrier check
type:refactor
Refactor codes or add tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3266 (BA-9)
Checklist: (if applicable)