fix(BA-515): Let the vfolder REST API accept vfolder UUIDs as intended #3451
+362
−384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: octodog <mu001@lablup.com>
github-actions
bot
added
area:docs
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
…nstead of directly reading request.match_info
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
3 tasks
fregataa
reviewed
Jan 15, 2025
…accessible VFolders
Co-authored-by: octodog <mu001@lablup.com>
… doc (#3460) Co-authored-by: octodog <mu001@lablup.com> Co-authored-by: Sanghun Lee <sanghun@lablup.com>
Co-authored-by: octodog <mu001@lablup.com>
lablup-octodog
added a commit
that referenced
this pull request
Jan 17, 2025
#3451) Co-authored-by: octodog <mu001@lablup.com> Co-authored-by: Sanghun Lee <sanghun@lablup.com> Co-authored-by: Sion Kang <siontama@gmail.com> Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3451
agatha197
added a commit
to lablup/backend.ai-webui
that referenced
this pull request
Jan 17, 2025
resolves #3039 (FR-372) related PR: lablup/backend.ai#3451 Adds support for vfolder ID-based operations in the backend client and updates related components to handle both name-based and ID-based folder operations. This change enables more reliable folder management by using unique IDs instead of potentially ambiguous folder names. **Changes:** - Introduces `vfolder-id-based` feature flag for manager versions 25.1.0, 24.09.5, and 24.03.11 - Updates folder operations (clone, rename, share, info) to use folder IDs when supported - Modifies file operations within folders to use the appropriate identifier - Updates UI components to handle both ID and name-based operations seamlessly **How to check:** 1. checkout core branch. refer: lablup/backend.ai#3451 2. check [BA-518](https://lablup.atlassian.net/browse/BA-518) in webui part. 3. modify manager compatible versions in esm file for testing **Checklist:** - [ ] Documentation - [x] Minimum required manager version: 24.03.12, 24.09.6, or 25.1.0 - [ ] Test case(s) to demonstrate the difference of before/after [BA-518]: https://lablup.atlassian.net/browse/BA-518?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3450 (BA-515)
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3451.org.readthedocs.build/en/3451/
📚 Documentation preview 📚: https://sorna-ko--3451.org.readthedocs.build/ko/3451/