fix(BA-507): GQL compute_session.vfolder_mounts returns folder id
#3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
github-actions
bot
added
area:docs
fregataa
force-pushed
the
fix/resolver-of-vfolder-mounts-in-compute-session
branch
from
cdd752b to
df413fc
Compare
github-actions
bot
added
size:XS
5 tasks
5 tasks
ironAiken2
requested changes
Jan 20, 2025
fregataa
force-pushed
the
fix/resolver-of-vfolder-mounts-in-compute-session
branch
from
6c6d570 to
34b6c31
Compare
Co-authored-by: octodog <mu001@lablup.com>
HyeockJinKim
deleted the
fix/resolver-of-vfolder-mounts-in-compute-session
branch
lablup-octodog
added a commit
that referenced
this pull request
Jan 23, 2025
…3461) Co-authored-by: octodog <mu001@lablup.com> Backported-from: main (25.1) Backported-to: 24.09 Backport-of: 3461
yomybaby
pushed a commit
to lablup/backend.ai-webui
that referenced
this pull request
Jan 24, 2025
…using vfolder_mounts (#3038) resolves #3051 (FR-249) <!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. --> >lablup/backend.ai#3461 PR must be merged first. <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> This PR makes folder explorer available in the Session Detail Panel. In versions prior to Backend.AI Core 24.12.0, the vfolder_nodes field is not provided. Therefore, you must use the `mounts` field of the `compute_session_node` query. Mounts field does not provide vfolder name. So we need to use `vfolder_mounts` field in legacy `compute_session` query. vfolder_mounts' provide the name of the vfolder in the same order as the `mounts' field in `compute_session_node'. **Feature:** - allow to open folder explorer in session detail panel **How to test:** - checkout Core branch to [lablup/backend.ai#3461](lablup/backend.ai#3461) - open session detail panel. you can open session detail panel via using query string (?sessionDetail=<sessionID>) - click the folder icon in session detail panel - Verify that folder opener works for the vfolder you clicked on (name, contents, etc. match) **Checklist:** (if applicable) - [ ] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
seedspirit
pushed a commit
that referenced
this pull request
Feb 4, 2025
…3461) Co-authored-by: octodog <mu001@lablup.com>
seedspirit
pushed a commit
that referenced
this pull request
Feb 5, 2025
…3461) Co-authored-by: octodog <mu001@lablup.com>
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
…3461) Co-authored-by: octodog <mu001@lablup.com>
Yaminyam
pushed a commit
that referenced
this pull request
Feb 12, 2025
…3461) Co-authored-by: octodog <mu001@lablup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3437 (BA-507)
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--3461.org.readthedocs.build/en/3461/
📚 Documentation preview 📚: https://sorna-ko--3461.org.readthedocs.build/ko/3461/