Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: milvus #3004

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix: milvus #3004

merged 1 commit into from
Oct 28, 2024

Conversation

FinleyGe
Copy link
Contributor

disable autoId when creating collections.
generate a safe integer id for collection when inserting.

Copy link

sweep-ai bot commented Oct 28, 2024

Hey @FinleyGe, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the `generateId` function to verify:
1. The generated ID is always a safe integer (less than Number.MAX_SAFE_INTEGER)
2. The first digit is between 1-8
3. The total length is always 16 digits
4. Multiple calls generate unique IDs

📖 For more information on how to use Sweep, please read our documentation.

@c121914yu c121914yu merged commit 4e3d817 into labring:main Oct 28, 2024
3 checks passed
@FinleyGe FinleyGe deleted the fix/milvus branch October 28, 2024 09:51
shilin66 pushed a commit to shilin66/FastGPT that referenced this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants