Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): Fix the problem that the certificate of unbundled websit… #1871

Merged
merged 1 commit into from
Feb 23, 2024
Merged

fix(server): Fix the problem that the certificate of unbundled websit… #1871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion server/src/gateway/website-task.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,13 @@ export class WebsiteTaskService {
}

// delete website custom certificate if custom domain is set
if (site.state === DomainState.Deleted && site.isCustom) {

/* Certificates are only removed when you delete the application and unbind the custom runtime domain.
Starting, restarting and stopping the application does not remove certificates */
if (
(site.state === DomainState.Deleted && site.isCustom) ||
(site.state === DomainState.Active && site.phase === DomainPhase.Deleting)
) {
const waitingTime = Date.now() - site.updatedAt.getTime()

// delete custom domain certificate
Expand Down
Loading