-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker to build locally and in CI #26
Use docker to build locally and in CI #26
Conversation
… for a configurable mirror
This should probably be squash merged due to the messy history (I'm happy to handle this once approved) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty nice! Can't say I've ever used docker for anything before, but this is a decent step up from the typical build install process on Windows. Guess I'll need to actually learn docker now ;)
It has been a while since I have looked through Docker best practices carefully, so there may be good reasons not to follow these suggestions. |
Good call! I've relocated it.
I'm more hesitant on this one. Docker user/permission stuff on linux/OSX systems always gets messy. I think I'll merge as-is but open an issue around it. It might be as simple as using a slightly different command to run docker, or an addition to the docker compose file, or a wrapper script that passes in the current UID/GID to docker (although I've had trouble with the one in the past due to needing to create users with those UID/GUD in the container when building which is hard). |
This adds docker configuration files so that PrawnBlaster firmware can be built within a docker container on personal devices and in GitHub actions.
Changes