-
Notifications
You must be signed in to change notification settings - Fork 69
Keysight Oscilloscope Implementation with pyVISA #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Initialization Only:
Need later to compare with own Oscilloscope implementation
Hello Kerim! Thank you for this addition! It looks very good. Scopes have always been an annoyance in labscript since they have so many inter-linked parameters that fully specifying them is a pain. Leveraging the internal saved-configs to provide some level of programmability while maintaining typical manual configuration by the user is a nice compromise. It is going to be a little while before I have time to fully review this (at which point I will no doubt have many little suggestions and probably a few larger ones). I'll ask a few questions now from my first read-through of the code, mostly focusing on the capabilities definition/connection_manager machinery:
|
… logic into LabscriptDevice Refactored connection logic: Removed the ConnectionManager class and implemented its core functionality directly in the LabscriptDevice class, enabling connection to the oscilloscope based on serial_number. Deprecated unused code: Removed oscilloscope capabilities since they are not currently in use.
Hello David, I appreciate your feedback on this. Here’s my response to your questions/comments:
|
Hi,
I am a physics student working with the APQ (Atoms-Photons-Quanta) group at the University of Darmstadt.
As part of my work, I integrated Keysight oscilloscopes into labscript which may be a nice addition for the community. It basically allows you to configure an osci via LAN or USB and acquire data on an external trigger. The oscilloscope configurations can be set on the device, saved in one of the config slots via a button in the blacs tab, and then be loaded by its id in the experiment shot. All configurations are displayed in blacs with their current values. Please see the README file for further information.
I will be happy to answer any questions.
Best reagards
Kerim Takouti