Changed np.string_ to np_bytes to work with numpy>=2.0 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dihm
previously approved these changes
Nov 18, 2025
Contributor
dihm
left a comment
dihm
left a comment
There was a problem hiding this comment.
Thank you for the quick fix!
Contributor
|
I went ahead and used ruff's NPY201 check to see if there were others to fix at the same time, and there are a couple. I went ahead and pushed those changes to your branch and will merge them all together as one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed np.string_ to np_bytes to work with numpy>=2.0 to address #131.
This should be an unnoticeable change since numpy.string_ was an alias of numpy.bytes_.