Fix recent AI termination changes to work with DAQs that don't have analog inputs #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't actually have any analog inputs.
|
Ugh. Docs builds just crashed because of a package update on |
dihm
added a commit
that referenced
this pull request
Dec 15, 2021
Fix recent AI termination changes to work with DAQs that don't have analog inputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just tried the changes in #75 on a DAQ without analog inputs and found a fairly important edge case in the logic. Basically, the changes I made assume analog inputs exist.
This PR adds a bit of logic to handle the case when the DAQ has no analog inputs.