Skip to content

Failure when there is no master pseudoclock is ungraceful #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philipstarkey opened this issue Oct 4, 2014 · 1 comment
Closed

Failure when there is no master pseudoclock is ungraceful #12

philipstarkey opened this issue Oct 4, 2014 · 1 comment
Labels
bug Something isn't working major

Comments

@philipstarkey
Copy link
Member

Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


If you don't define a master pseudoclock (or any devices), you get this obtuse thing:

#!python

Traceback (most recent call last):
  File "/home/bilbo/Desktop/user_scripts/labscriptlib/spinor/__init__.py", line 8, in <module>
    start()
  File "/home/bilbo/bitbucket_clones/labscript/labscript.py", line 1593, in start
    master_pseudoclock, = [pseudoclock for pseudoclock in all_pseudoclocks if pseudoclock.is_master_pseudoclock]
ValueError: need more than 0 values to unpack

This is pretty simple, let's put a better error message there if stop() gets called and there is no master pseudoclock

@philipstarkey
Copy link
Member Author

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


  • changed state from "new" to "resolved"

Resolves issue #14 and issue #12

→ <<cset 40ccc11>>

@philipstarkey philipstarkey added major bug Something isn't working labels Apr 5, 2020
Loki27182 pushed a commit to Loki27182/labscript that referenced this issue Oct 9, 2023
Loki27182 pushed a commit to Loki27182/labscript that referenced this issue Oct 9, 2023
…labscript-suite#14), which was

modifications that removed the requirement for there to be a pseudoclock
Loki27182 pushed a commit to Loki27182/labscript that referenced this issue Oct 9, 2023
Provides start_order and stop_order as per Issue labscript-suite#18.

Approved-by: Chris Billington <chrisjbillington@gmail.com>
Loki27182 pushed a commit to Loki27182/labscript that referenced this issue Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant