Added possibility to customize span operationName #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extended TracerConfig with OperationNameFunc which allows to override default operation name during span creation. If there is no OperationNameFunc provided then fallback will be used which covers most of the use-cases.
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 59.43% 59.79% +0.35%
==========================================
Files 8 8
Lines 673 679 +6
==========================================
+ Hits 400 406 +6
Misses 252 252
Partials 21 21
Continue to review full report at Codecov.
|
aldas
requested changes
Jun 19, 2022
jaegertracing/jaegertracing.go
Outdated
| @@ -62,6 +62,9 @@ type ( | |||
| // http body limit size (in bytes) | |||
| // NOTE: don't specify values larger than 60000 as jaeger can't handle values in span.LogKV larger than 60000 bytes | |||
| LimitSize int | |||
|
|
|||
| // OperationNameFunc composes operation name based on context. Can be used to override default naming | |||
| OperationNameFunc func(ctx echo.Context) string | |||
There was a problem hiding this comment.
Please rename that parameter from ctx to c. Named parameters are handy when your IDE (for example GoLand by Jetbrains) does autocompletion and helps to autofill names. By convention echo.Context is usually named as c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended
TracerConfigwithOperationNameFuncproperty which allows to override default operation name during span creation.If there is no
OperationNameFuncprovided then fallback will be used which covers most of the use-cases.