Using http.handler as an handler

[gaurishhs]

Hi! i have a library which provides me with http.handler for my routes, How can i set them up? I used to do gin.WrapH when i was using Gin-Gonic, Migrating from it to Echo.

Thanks

[aldas]

There is echo.WrapHandler that you can use to wrap http.Handler into handler

echo/echo.go

Lines 888 to 894 in 82a964c

	// WrapHandler wraps `http.Handler` into `echo.HandlerFunc`.
	func WrapHandler(h http.Handler) HandlerFunc {
	return func(c Context) error {
	h.ServeHTTP(c.Response(), c.Request())
	return nil
	}
	}

Here is example with it: https://echo.labstack.com/cookbook/embed-resources/

[gaurishhs]

@aldas Hi! I tried using echo.WrapHandler with https://github.com/go-pkgz/auth and it doesn't seem to work properly.. I get a 404 on all the WrapHandler routes. Do you think this could be an issue on the package side?

This is the function that returns the handlers

https://github.com/go-pkgz/auth/blob/dc03f5df7e6adec282432ed77fc77dae9617f013/auth.go#L149-L218

My server code:

func main() {
	e := echo.New()
	// auth initalization stuff here
	authRoutes, avaRoutes := authService.Handlers()

	// Middlewares
	e.Use(middleware.Recover())
	e.Use(middleware.CORS())
	e.Use(middleware.Secure())

	// Routes
	e.GET("/auth", echo.WrapHandler(authRoutes))
	e.GET("/avatar", echo.WrapHandler(avaRoutes))
	// Start server
	if err := e.Start(":8080"); err != http.ErrServerClosed {
		log.Fatal(err)
	}
}

[aldas]

Easiest way to find out would be to add breakpoint in your IDE or temporarily change echo.WrapHandler(authRoutes) to some simple echo handler. ala:

	e.GET("/auth", func(c echo.Context) error {
		return c.String(http.StatusOK, "auth")
	})

and submit your request again to see where the execution ends up.

[gaurishhs]

it works as expected.. No issues Returns a string "auth" with status 200

[aldas]

I think https://github.com/go-pkgz/auth/blob/dc03f5df7e6adec282432ed77fc77dae9617f013/auth.go#L149-L218 works by using certain parts of url. So when you add that route. It probably needs to be catch all e.GET("/auth*", echo.WrapHandler(authRoutes)). At the moment with "/auth" only exact matches are matched and used.

[gaurishhs]

You're right. It works after adding a *