Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware HTTPSNonWWWRedirect out of range 4 #1811

Closed
syssam opened this issue Mar 16, 2021 · 1 comment · Fixed by #1813
Closed

Middleware HTTPSNonWWWRedirect out of range 4 #1811

syssam opened this issue Mar 16, 2021 · 1 comment · Fixed by #1813
Labels
bug middleware
Milestone
v4.2.2

Comments

@syssam
Copy link

syssam commented Mar 16, 2021 •
edited
Loading

Middleware HTTPSNonWWWRedirect out of range 4
@syssam syssam changed the title HTTPSNonWWWRedirectWithConfig out of range 4 Middleware HTTPSNonWWWRedirect out of range 4 Mar 16, 2021
@aldas
Copy link
Contributor

aldas commented Mar 16, 2021

I assume this is about case when host value is shorter than 4 characters in redirect middleware.

echo/middleware/redirect.go

Line 83 in dec96f0

if host[:4] == www {

There seems to be multiple places in that middleware that could problematic when host is too short.

aldas added a commit to aldas/echo that referenced this issue Mar 16, 2021
@aldas
fix redirect middleware panicing on short host name (fix labstack#1811)
e80c353
@aldas aldas mentioned this issue Mar 16, 2021
Merged
@lammel lammel added this to the v4.3 milestone Mar 17, 2021
@lammel lammel modified the milestones: v4.3, v4.2.2 Apr 6, 2021
lammel pushed a commit that referenced this issue Apr 6, 2021
@aldas
Fix panic in redirect middleware on short host name (fix #1811) (#1813)
ae4665c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug middleware
Projects
None yet
Milestone
v4.2.2
Development

Successfully merging a pull request may close this issue.

fix redirect middleware panicing on short host name (fix #1811) aldas/echo
3 participants
@lammel @aldas @syssam