Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Echo#Reverse for Any type routes #1695

Merged
merged 1 commit into from
Dec 6, 2020

Conversation

pafuent
Copy link
Contributor

@pafuent pafuent commented Nov 24, 2020

Fixes #1690

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1695 (5f1aa1b) into master (17a5fca) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1695   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          29       29           
  Lines        1938     1938           
=======================================
  Hits         1642     1642           
  Misses        188      188           
  Partials      108      108           
Impacted Files Coverage Δ
echo.go 84.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17a5fca...5f1aa1b. Read the comment docs.

@pafuent pafuent self-assigned this Nov 26, 2020
@lammel
Copy link
Contributor

lammel commented Dec 6, 2020

@pafuent Lovely thanks.
I hope noone relies on that undocumented behaviour.

@lammel lammel merged commit 429a8db into labstack:master Dec 6, 2020
@pafuent pafuent deleted the reverse_any_type_routes branch December 10, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Echo.Reverse doesn't handle * parameters
2 participants