Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support form fields in jwt middleware #1704

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Conversation

rkfg
Copy link
Contributor

@rkfg rkfg commented Dec 1, 2020

Support passing JWT tokens in form fields
Closes #1697

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1704 (2152e4e) into master (502cce2) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1704      +/-   ##
==========================================
+ Coverage   84.88%   84.93%   +0.05%     
==========================================
  Files          29       29              
  Lines        1945     1952       +7     
==========================================
+ Hits         1651     1658       +7     
  Misses        187      187              
  Partials      107      107              
Impacted Files Coverage Δ
middleware/jwt.go 77.89% <100.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 502cce2...2152e4e. Read the comment docs.

Copy link
Contributor

@iambenkay iambenkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fab!

@iambenkay
Copy link
Contributor

@lammel

@lammel
Copy link
Contributor

lammel commented Dec 6, 2020

Thanks @rkfg for your contribution and @iambenkay for review!

@lammel lammel merged commit 6a266b8 into labstack:master Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add form field support for JWT middleware
3 participants