Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds test for request id #1719

Merged
merged 1 commit into from
Dec 15, 2020
Merged

adds test for request id #1719

merged 1 commit into from
Dec 15, 2020

Conversation

iambenkay
Copy link
Contributor

Test to ensure correct behaviour of request id middleware when Request ID is provided from requester
closes #1714

@iambenkay
adds test for request id
1c72059 
- remain unchanged if provided
pafuent
pafuent approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@pafuent pafuent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the quality of Echo!!!

@pafuent pafuent merged commit e7741d4 into labstack:master Dec 15, 2020
@iambenkay iambenkay deleted the chore/request-id-test branch December 15, 2020 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pafuent pafuent pafuent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit Test on RequestId Middleware to validate requests with a X-Request-ID header
2 participants
@iambenkay @pafuent