panics in timeout middleware are not recovered and cause application to crash

[aldas]

Fix #1794: panics in timeout middleware are not recovered and cause application to crash (as those happen in different goroutine outside of recover middleware)

[codecov]

Codecov Report

Merging #1795 (c239a87) into master (c79ffed) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1795      +/-   ##
==========================================
+ Coverage   89.73%   89.75%   +0.02%     
==========================================
  Files          32       32              
  Lines        2669     2675       +6     
==========================================
+ Hits         2395     2401       +6     
  Misses        175      175              
  Partials       99       99              

Impacted Files	Coverage Δ
middleware/timeout.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c79ffed...c239a87. Read the comment docs.

[aldas]

This can be reproduced with following app setup

func main() {
	e := echo.New()

	e.Use(middleware.TimeoutWithConfig(middleware.TimeoutConfig{
		Timeout: 10 * time.Millisecond,
	}))

	e.GET("/", func(c echo.Context) error {
		panic("panic!!!")
	})

	e.Start(":8080")
}

curl -v http://localhost:8080/

[lammel]

Looks good, now the error of the spun-off go routine is even logged.

This is real Go wizardry ;-) Great @aldas !