-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1787: Add support for optional filesystem to the static middleware #1797
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1797 +/- ##
==========================================
- Coverage 89.56% 89.54% -0.03%
==========================================
Files 32 32
Lines 2646 2659 +13
==========================================
+ Hits 2370 2381 +11
Misses 178 178
- Partials 98 100 +2
Continue to review full report at Codecov.
|
NB: you might want to try static tests with I think the change may not be that simple as |
@aldas Thank you for your super quick codereview!
Great idea to use build tags! Go did not let me use
Which validation exactly do you mean? What I saw so far is that
Well I am glad you caught that one! I reverted back to |
well I was just tinkering around and saw your PR. I tried solve same thing ( couple of days ago ) by going |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
This PR is related to #1787.
By supporting
http.Filesystem
we also provide support for the newfs.FS
while maintaining compatibility with versions prior to go1.16.