Add Go 1.16 to CI and drop 1.12 specific code #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
=======================================
Coverage 89.57% 89.57%
=======================================
Files 32 31 -1
Lines 2686 2686
=======================================
Hits 2406 2406
Misses 180 180
Partials 100 100
Continue to review full report at Codecov.
|
lammel
reviewed
Apr 15, 2021
middleware/proxy_test.go
Outdated
| @@ -302,3 +305,73 @@ func TestProxyRewriteRegex(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestProxy_1_11(t *testing.T) { | |||
There was a problem hiding this comment.
Is this related to Go 1.11 somehow or why is its name suffixed with _1_11? (Just curios, looks like a normal proxy test)
|
Say a final farewell to Go 1.12 or earlier. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Go 1.16 to CI and drop 1.12 specific code
I'll open this in favor of #1839