-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds JWTConfig.ParseTokenFunc to JWT middleware to allow different libraries implementing JWT parsing. #1887
Conversation
…braries implementing JWT parsing.
Codecov Report
@@ Coverage Diff @@
## master #1887 +/- ##
==========================================
+ Coverage 90.21% 90.61% +0.40%
==========================================
Files 31 31
Lines 2770 2782 +12
==========================================
+ Hits 2499 2521 +22
+ Misses 173 168 -5
+ Partials 98 93 -5
Continue to review full report at Codecov.
|
@lammel please review this PR. This will allow people to use forks of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Seems like a step in the right direction. I'd really like to remove the dependency on jwt-go in the future as still people will think that we are vulnerable to security issues raised against jwt-go. We probably should add a hint on the security issue in the docs too. |
@lammel docs will come this this PR labstack/echox#213 |
* Add JWTConfig.ParseTokenFunc for labstack/echo#1887
Adds JWTConfig.ParseTokenFunc to JWT middleware to allow different libraries implementing JWT parsing.
This tries to address problems that
github.com/dgrijalva/jwt-go
is unmaintained and as we use types from that library we can not change out implementation without breaking change.Example how different version of
github.com/dgrijalva/jwt-go
can be used with this Echo version