-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[suggestion] Add helper interface for ProxyBalancer interface #2316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add additional test for returning error and not proxing the request, as it was the reason for creating this PR.
Codecov ReportBase: 92.35% // Head: 92.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2316 +/- ##
==========================================
+ Coverage 92.35% 92.37% +0.01%
==========================================
Files 37 37
Lines 4436 4446 +10
==========================================
+ Hits 4097 4107 +10
Misses 247 247
Partials 92 92
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thank you!
Idea is discussed in this issue