-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs for #1736 fluent binder #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR includes the docs of #169, so maybe this could be merged instead of it if the Fluent Binder PR gets merged soon
website/content/guide/request.md
Outdated
``` | ||
|
||
### Methods | ||
`FailFast` flags binder to stop binding after first bind error during binder call chain. Enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think FailFast should include the () to be consistent
website/content/guide/request.md
Outdated
|
||
* `<Type>("param", &destination)` - if parameter value exists then binds it to given destination of that type i.e `Int64(...)`. | ||
* `Must<Type>("param", &destination)` - parameter value is required to exist, binds it to given destination of that type i.e `MustInt64(...)`. | ||
* `<Type>s("param", &destination)` - (for slices) if parameter values exists then binds it to given destination of that type i.e `I`nt64s(...)`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here there is a extra ` after the I (`I`nt64s(...)`)
website/content/guide/request.md
Outdated
* `<Type>s("param", &destination)` - (for slices) if parameter values exists then binds it to given destination of that type i.e `I`nt64s(...)`. | ||
* `Must<Type>s("param", &destination)` - (for slices) parameter value is required to exist, binds it to given destination of that type i.e `MustInt64s(...)`. | ||
|
||
for some slice types `BindWithDelimiter("param", &dest, ",")` supports slitting parameter values before type conversion is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo on slitting
Mention `UnixTimeNano()` as supported fluent binder function
lgtm. I added 2 little changes:
splitting binder to its own page is good move. It is easier to find it on site. |
Docs for:
Maybe someone with better English takes time to edit wording etc if needed.