do not rely on undefined behaviour in bytes_test.go #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
=======================================
Coverage 59.26% 59.26%
=======================================
Files 6 6
Lines 518 518
=======================================
Hits 307 307
Misses 208 208
Partials 3 3 Continue to review full report at Codecov.
|
8 exbi equals 2^64, therefore it cannot be stored in int64. The tests use the fact that on x86_64 the following expressions holds true: int64(0) - 1 == math.MaxInt64. However, this is not true for other platforms, specifically aarch64, s390x and ppc64le. This commit fixes it by testing the library with 7 exbi. Fixes labstack#37
ondrejbudai
force-pushed
the
fix-undefined-behaviour-in-tests
branch
from
2337700
to
5c8aceb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8 exbi equals 2^64, therefore it cannot be stored in int64. The tests use
the fact that on x86_64 the following expressions holds true:
int64(0) - 1 == math.MaxInt64.
However, this is not true for other platforms, specifically aarch64, s390x
and ppc64le.
This commit fixes it by testing the library with 7 exbi.
Fixes #37