Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install cli only #86

Merged
merged 3 commits into from
Jul 19, 2022
Merged

Conversation

Roedy13
Copy link
Contributor

@Roedy13 Roedy13 commented Jun 27, 2022

#85

Added CMake option BUILD_GUI to allow compiling the command line client without the GUI when it is not needed.

To invoke (linux)

mkdir build && cd build && cmake ../ -DBUILD_GUI=OFF

Tested compilation in

Debian 11 5.10.0-15-amd64
cmake version 3.23.2

Windows 10 Pro (vm) build 19044.1766
VS Code 17.2.5

@cboulay
Copy link
Contributor

cboulay commented Jun 27, 2022

Can you make it BUILD_GUI and default to ON? That is a lot more intuitive and we won't need all the if (NOTs in there.

@Roedy13
Copy link
Contributor Author

Roedy13 commented Jun 27, 2022

Sure thing

@Roedy13
Copy link
Contributor Author

Roedy13 commented Jul 19, 2022

@cboulay How are we looking here?

@cboulay
Copy link
Contributor

cboulay commented Jul 19, 2022

Looks good. Let's see what happens.
Thanks!

@cboulay cboulay merged commit e304657 into labstreaminglayer:master Jul 19, 2022
@Roedy13 Roedy13 deleted the install_cli_only branch July 19, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants