Skip to content

Native threaded concurrency #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 15, 2020
Merged

Native threaded concurrency #120

merged 9 commits into from
Jul 15, 2020

Conversation

jtc42
Copy link
Member

@jtc42 jtc42 commented Jul 15, 2020

Switches to native threading for concurrency, and uses labthings/flask-threaded-sockets for websocket support.

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #120 into master will decrease coverage by 1.03%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
- Coverage   92.75%   91.72%   -1.04%     
==========================================
  Files          46       46              
  Lines        1863     1836      -27     
  Branches      306      312       +6     
==========================================
- Hits         1728     1684      -44     
- Misses         88       99      +11     
- Partials       47       53       +6     
Flag Coverage Δ
#unittests 91.72% <80.95%> (-1.04%) ⬇️
Impacted Files Coverage Δ
src/labthings/sockets.py 71.42% <ø> (-22.96%) ⬇️
src/labthings/view/__init__.py 83.80% <0.00%> (-0.12%) ⬇️
src/labthings/tasks/thread.py 84.86% <71.79%> (-14.07%) ⬇️
src/labthings/tasks/pool.py 87.50% <83.33%> (+5.50%) ⬆️
src/labthings/default_views/actions.py 100.00% <100.00%> (ø)
src/labthings/default_views/tasks.py 100.00% <100.00%> (ø)
src/labthings/labthing.py 97.01% <100.00%> (ø)
src/labthings/sync/event.py 94.11% <100.00%> (-1.13%) ⬇️
src/labthings/sync/lock.py 90.80% <100.00%> (-1.04%) ⬇️
src/labthings/utilities.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2da89...f3ddce1. Read the comment docs.

@jtc42 jtc42 merged commit 506a026 into master Jul 15, 2020
@jtc42 jtc42 deleted the threaded-ws branch September 9, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant