feat(lql): add option to generate empty lql file #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a flag when running `lacework query run` to create an empty file in `$EDITOR`, rather than using the default template
emmaisadev
force-pushed
the
feat/emptylql
branch
from
d8ef4b8 to
1174596
Compare
pass the linter checks for Go
emmaisadev
force-pushed
the
feat/emptylql
branch
from
1174596 to
28bc0ab
Compare
this adjusts the formatting to pass the linter
includes new text for help
afiune
approved these changes
Oct 13, 2023
afiune
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a flag when running
lacework query runto create an empty file in$EDITOR, rather than using the default template.This is a useful feature for policy engineering work, as when we have a draft query already created, that we want to quickly test, it allows to just paste into an empty file and run the query.
How did you test this change?
All changes tested locally using the testing procedure defined via the
makerules.Also verified that the resulting
laceworkbinary behaves correctly using the new flag.Issue
N/A