chore(cli): add info about false-positive virus on Windows #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we upgraded to go version `1.21`, Chocolatey started flagging our binaries: https://community.chocolatey.org/packages/lacework-cli#virus  This is a common false-positive so this PR is adding this "banner" to explain: --- **Important Notice** Since the release of the Lacework CLI version `1.30.0` we noticed that the virus scan reports positive findings. We have analyzed the generated binaries and we have not found any virus. This is a **common false-positive** in the Golang community for Windows binaries. For details, go to https://golang.org/doc/faq#virus --- Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
afiune
force-pushed
the
afiune/windows-virus-false-positive
branch
from
d785f22 to
ea2517c
Compare
PengyuanZhao
approved these changes
Sep 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When we upgraded to go version
1.21, Chocolatey started flagging our binaries:https://community.chocolatey.org/packages/lacework-cli#virus
This is a common false-positive so this PR is adding this "banner" to explain:
Important Notice
Since the release of the Lacework CLI version
1.30.0we noticed that the virus scan reports positive findings. Wehave analyzed the generated binaries and we have not found any virus.
This is a common false-positive in the Golang community for Windows binaries. For details, go to https://golang.org/doc/faq#virus
Supporting Links