Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add short lived instance field in agentless data structs #1399

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

wl-smith
Copy link
Contributor

@wl-smith wl-smith commented Oct 4, 2023

Summary

In order to go fully-GA on the short-lived feature for AWS for Agentless Workload scanning, we need to also update the terraform to have a field for short-lived instances. I've added the field to both AWLS and AWLS Org integration types. This feature is not currently available on GCP.

How did you test this change?

Tested via integration tests, added additional field in the integration tests.

Issue

https://lacework.atlassian.net/browse/RAIN-71760

@wl-smith wl-smith force-pushed the add-short-lived-instance-field-agentless branch from 6a465d7 to b2bc439 Compare October 4, 2023 22:04
@wl-smith wl-smith force-pushed the add-short-lived-instance-field-agentless branch 2 times, most recently from 4215018 to ed171a0 Compare October 17, 2023 17:29
@wl-smith wl-smith marked this pull request as ready for review October 17, 2023 17:46
@wl-smith wl-smith requested a review from a team as a code owner October 17, 2023 17:46
@wl-smith wl-smith force-pushed the add-short-lived-instance-field-agentless branch from ed171a0 to 54f0d50 Compare October 27, 2023 16:31
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wl-smith wl-smith merged commit 478dcaa into main Oct 27, 2023
1 check passed
@wl-smith wl-smith deleted the add-short-lived-instance-field-agentless branch October 27, 2023 17:02
@lacework-releng lacework-releng mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants