feat(resource-groups): add support for OCI #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix up comment CAD-416
dmurray-lacework
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Looks good @hazedav
Could you also update integration/context/ctx.toml#L159 with the resource-groups build tag and and the resource_groups.go. This is for integration context based tests. Eg:
[resource-groups]
files = [
"resource_groups.go",
]
dirs = []
|
integration all ^ Run all integration tests |
Add resource groups to integration context map CAD-416
|
integration resource_groups |
|
integration all |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for new resource group type
OCIHow did you test this change?
Issue
https://lacework.atlassian.net/browse/CAD-416