Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): windows integration tests #1427

Merged
merged 4 commits into from
Oct 31, 2023
Merged

fix(ci): windows integration tests #1427

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4c4cfb
fix(ci): windows integration tests
afiune Oct 30, 2023
7890730
chore: run on windows
afiune Oct 30, 2023
aecd9bf
fix(ci): more windows integration tests
afiune Oct 30, 2023
1e8928f
Revert "chore: run on windows"
afiune Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions integration/help_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ func TestHelpAll(t *testing.T) {
if runtime.GOOS == "windows" {
canon, err := helpCanon.ReadFile(windowsFilePath)
if err == nil {
assert.Equal(t, string(canon), out.String())
assert.Equal(t, strings.ReplaceAll(string(canon), "\r", ""), out.String())
return
}
}
canon, _ := helpCanon.ReadFile(filePath)
assert.Equal(t, string(canon), out.String())
assert.Equal(t, strings.ReplaceAll(string(canon), "\r", ""), out.String())
})
}
}
Expand Down Expand Up @@ -129,7 +129,7 @@ func TestNoCommandProvided(t *testing.T) {
out, err, exitcode := LaceworkCLI()
canon, _ := helpCanon.ReadFile("test_resources/help/no-command-provided")
assert.Equal(t,
string(canon),
strings.ReplaceAll(string(canon), "\r", ""),
out.String(),
"the main help message changed, please update")
assert.Empty(t,
Expand Down