Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GROW-2556): enable azure storage account infra encryption #1431

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Nov 2, 2023

Summary

Enable Infrastructure Encryption by default when creating a new Azure Storage Account for activity log integration.

How did you test this change?

  • updated automated tests
  • executed manually

Issue

https://lacework.atlassian.net/browse/GROW-2556

Enable Infrastructure Encryption by default when creating a new Azure
Storage Account for activity log integration.
@ipcrm ipcrm requested a review from a team as a code owner November 2, 2023 17:54
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

Does this "encryption feature" requires more permissions? I am thinking about our Deployment Role for Azure and how will we codify this into a Checklist (in the future)

@ipcrm
Copy link
Contributor Author

ipcrm commented Nov 2, 2023

re: permissions, not to my knowledge because it's CSP managed (in this case)

@ipcrm ipcrm merged commit fa93e65 into main Nov 2, 2023
1 check passed
@ipcrm ipcrm deleted the ipcrm/GROW-2556/azure-activity-log-generate branch November 2, 2023 19:20
@lacework-releng lacework-releng mentioned this pull request Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants