-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add org-cloudtrail to lw_generate #1433
feat: add org-cloudtrail to lw_generate #1433
Conversation
1c3e030
to
56ad547
Compare
8470cb5
to
c797ed2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Have we tested this using our AWS organization account?
Jamie has done some testing of the cloudtrail terraform with main output with his own account. We need to release the cloudtrail module for before we merge this. |
An issue with testing. The LW provider block needs to have the organization = true setting |
Signed-off-by: Darren Murray <darren.murray@lacework.net>
131c1da
to
1de31b3
Compare
Signed-off-by: Darren Murray <darren.murray@lacework.net> feat: cloudtrail org account mapping Signed-off-by: Darren Murray <darren.murray@lacework.net>
1de31b3
to
43427f6
Compare
Branched from #1424
Summary
Add support for organization cloudtrail setting in the lw_generate cloudtrail module
How did you test this change?
integration/aws_generation_test.go
TestGenerationAwsCloudtrailOrganization
TestGenerationCloudtrailOrgMappingsNonInteractive
TestGenerationAwsCloudtrailOrganizationAccountMappings
Issue
https://lacework.atlassian.net/browse/GROW-2504