Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Every
lacework component list
makes N+1 API calls: APIlist all components
, and for N components APIlist all versions
.This PR proposes to fix this by only calling the
list all versions
API endpoint when a users runslacework component show
. This means thatlacework component list
is a single API call, andlacework component show
is 2 API calls.The catch is that a user will only see the
Tainted
status after they runlacework component show
. Until they run that command, the version will beUpdate Available
.How did you test this change?
Issue
https://lacework.atlassian.net/browse/GROW-2771