Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: integration tests pipeline improvements #1564

Merged
merged 13 commits into from
Feb 28, 2024
Merged

ci: integration tests pipeline improvements #1564

merged 13 commits into from
Feb 28, 2024

Conversation

PengyuanZhao
Copy link
Contributor

@PengyuanZhao PengyuanZhao commented Feb 26, 2024 •
edited
Loading

Summary

  • Use the --rerun-fails flag to rerun failed tests 2 more times.
  • Run make build instead of make build-cli-cross-platform for faster build
  • Use Github Action job matrix to run integration tests with different build tags in parallel.
  • Fix LQL tests issues caused by the enabling of the lpp_rego_enabled featured flag.

How did you test this change?

https://github.com/lacework/go-sdk/actions/runs/8072320718

Issue

https://lacework.atlassian.net/browse/GROW-2770

@PengyuanZhao PengyuanZhao changed the title test: show integration tests details test: integration tests improvements Feb 27, 2024
@PengyuanZhao PengyuanZhao marked this pull request as ready for review February 27, 2024 22:15
@PengyuanZhao PengyuanZhao requested a review from a team as a code owner February 27, 2024 22:15
ipcrm
ipcrm approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is a massive improvement!

@PengyuanZhao PengyuanZhao changed the title test: integration tests improvements ci: integration tests pipeline improvements Feb 28, 2024
@PengyuanZhao PengyuanZhao merged commit 9019e41 into main Feb 28, 2024
11 checks passed
@PengyuanZhao PengyuanZhao deleted the pengyuan/GROW-2770 branch February 28, 2024 15:22
@lacework-releng lacework-releng mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipcrm ipcrm ipcrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PengyuanZhao @ipcrm