Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: component download AWS XML error #1572

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

jon-stewart
Copy link
Contributor

Summary

AWS returns an XML error message when there is an issue with the presigned URL.

How did you test this change?

New unit test and locally against the gdevus1 cluster.

Problem:

> lacework component install component-example --version 0.8.2
 [✓] Component component-example found
| Staging component component-example... Downloaded: 0mb

...

- Staging component component-example... Downloaded: 0mb ERROR gzip: invalid header

Improvement:

> bin/lacework component install component-example --version 0.8.2                                                                             ~/Workspace/Lacework/go-sdk
 [✓] Component component-example found

...

ERROR Code: PermanentRedirect.  Message: The bucket you are attempting to access must be addressed using the specified endpoint. Please send all future requests to this endpoint.

Issue

https://lacework.atlassian.net/browse/GROW-2765

@jon-stewart jon-stewart self-assigned this Mar 1, 2024
@jon-stewart jon-stewart requested a review from a team as a code owner March 1, 2024 13:06
Copy link
Contributor

@PengyuanZhao PengyuanZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestCatalogInstall is failing.

@jon-stewart jon-stewart force-pushed the jon-stewart/GROW-2789/component-aws-error branch from 3b003b2 to 2c17d96 Compare March 1, 2024 15:32
@jon-stewart jon-stewart merged commit 9740f91 into main Mar 1, 2024
11 checks passed
@jon-stewart jon-stewart deleted the jon-stewart/GROW-2789/component-aws-error branch March 1, 2024 16:05
@lacework-releng lacework-releng mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants