Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GROW-2831): correct handling for resourceTags in policy exceptions #1605

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented Mar 29, 2024

Summary

Prior to this change the data format for resource tags was sent incorrectly, resulting in an ineffectual policy. This corrects that format issue so the policy works.

How did you test this change?

Manual execution & passing tests

Issue

https://lacework.atlassian.net/browse/GROW-2831

@ipcrm ipcrm requested a review from a team as a code owner March 29, 2024 13:25
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have tests but, this code is already a bit of spaghetti

@afiune afiune merged commit fbe45af into main Mar 29, 2024
11 checks passed
@afiune afiune deleted the ipcrm/GROW-2831/policy-exception-values branch March 29, 2024 15:33
@lacework-releng lacework-releng mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants