Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use buffered channel for downloadComplete to prevent blocking #1617

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: use buffered channel for downloadComplete to prevent blocking #1617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cli/cmd/component.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ func runComponentsInstall(cmd *cobra.Command, args []string) (err error) {
func installComponent(args []string) (err error) {
var (
componentName string = args[0]
downloadComplete = make(chan int8)
downloadComplete = make(chan int8, 1)
params map[string]interface{} = make(map[string]interface{})
start time.Time
)
Expand Down
Loading