Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GROW-2908): lwgenerate enable custom root terraform blocks and provider arguments #1626

Merged
merged 3 commits into from
May 16, 2024

Conversation

ipcrm
Copy link
Contributor

@ipcrm ipcrm commented May 15, 2024

Summary

Enable some advanced use cases for AWS lwgenerate that require adding custom hclwrite blocks to the root terraform block, the base hcl document, as well as being able to set provider arguments.

How did you test this change?

See unit tests.

Issue

https://lacework.atlassian.net/browse/GROW-2908

@ipcrm ipcrm force-pushed the ipcrm/GROW-2908/vars-and-backend branch from 432ba99 to a9a29ea Compare May 15, 2024 03:19
@ipcrm ipcrm force-pushed the ipcrm/GROW-2908/vars-and-backend branch from a9a29ea to 749e692 Compare May 15, 2024 13:12
@ipcrm ipcrm changed the title feat(GROW-2908): enable setting backend stub for terraform provider feat(GROW-2908): lwgenerate enable custom root terraform blocks and provider arguments May 15, 2024
@ipcrm ipcrm marked this pull request as ready for review May 16, 2024 04:02
@ipcrm ipcrm requested a review from a team as a code owner May 16, 2024 04:02
@ipcrm ipcrm requested a review from PengyuanZhao May 16, 2024 04:03
Copy link
Contributor

@PengyuanZhao PengyuanZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ipcrm ipcrm merged commit 8d50d31 into main May 16, 2024
12 checks passed
@ipcrm ipcrm deleted the ipcrm/GROW-2908/vars-and-backend branch May 16, 2024 14:23
@lacework-releng lacework-releng mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants